Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes behaviour after grape upgrade to 1.4.0. #801

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

LeFnord
Copy link
Member

@LeFnord LeFnord commented Jul 13, 2020

No description provided.

@dblock
Copy link
Member

dblock commented Jul 13, 2020

@LeFnord, what did Grape 1.4.0 break?

@coveralls
Copy link

coveralls commented Jul 13, 2020

Coverage Status

Coverage increased (+0.002%) to 99.47% when pulling 1f5e18a on LeFnord:master into 6db9641 on ruby-grape:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.472% when pulling fecfb4b on LeFnord:master into 6db9641 on ruby-grape:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.472% when pulling fecfb4b on LeFnord:master into 6db9641 on ruby-grape:master.

@LeFnord
Copy link
Member Author

LeFnord commented Jul 13, 2020

@dblock … most of the errors depended of this line … it seems declared_params changed, but this is only my guess

we observed a abd behaviour here

this PR will fix it, but also runs with 1.3.3

@dblock
Copy link
Member

dblock commented Jul 14, 2020

I bisected it to ruby-grape/grape#2077.

@dblock
Copy link
Member

dblock commented Jul 14, 2020

Looks like the order of setting internal :declared_params has changed, and there was no need to rely on it anymore since Grape < 1.0. I think this is safe to merge.

@LeFnord LeFnord merged commit e1261f8 into ruby-grape:master Jul 14, 2020
aka-momo pushed a commit to aka-momo/grape-swagger that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants